[BUG] repeatHeaderCount (incl. fix)

[Heart1010]

Hi,

a small bug with repeatHeaderCount config setting.

$intCurrentUserCount and $intPageUserCount are incremented right now for every user and only then, after that, there is the check if the user is hidden
Therefor the setting for repeatHeaderCount is interpreted wrong.

So I changed in file /include/showmonth.function.php (line ~607)

foreach ($users as $usr)
{
$intCurrentUserCount++;
$intPageUserCount++;
$monthBody='';
$U->findByName($usr['user']);
//print($usr['group']."|".$usr['user'].'<br>');

if ( !($U->status&$CONF['USHIDDEN']) )
{
if ( checkAuth("viewCalendar",$U->username) )
{

to

foreach ($users as $usr)
{
//$intCurrentUserCount++;
//$intPageUserCount++;
$monthBody='';
$U->findByName($usr['user']);
//print($usr['group']."|".$usr['user'].'<br>');

if ( !($U->status&$CONF['USHIDDEN']) )
{
$intCurrentUserCount++;
$intPageUserCount++;

if ( checkAuth("viewCalendar",$U->username) )
{

and everything works like it should!

[George]

Hi Heart1010
nice find! Thanks for sharing. WIll fix that in the next release.
Best regards,
George

[schmidts]

Hello,

i have just downloaded and installed tcpro version 3.4.0000 but i still got this error.

you have to move these two rowes a little bit more down to really take effect and to solve this problem:

orig:

Code: Select all

    foreach ($users as $usr)
        {
                $monthBody='';
                $U->findByName($usr['user']);
                //print($usr['group']."|".$usr['user'].'|curusercount:'.$intCurrentUserCount.'|pageusercount:'.$intPageUserCount.'<br>');

                if ( !($U->status&$CONF['USHIDDEN']) )
                {
                        $intCurrentUserCount++;
                        $intPageUserCount++;

                        if ( checkAuth("viewCalendar",$U->username) )
                        {
                                $intThisUsersPage = floor($intCurrentUserCount/$intUsersPerPage) + 1;

change to this fixed the problem for me:

Code: Select all

foreach ($users as $usr)
        {
                $monthBody='';
                $U->findByName($usr['user']);
                //print($usr['group']."|".$usr['user'].'|curusercount:'.$intCurrentUserCount.'|pageusercount:'.$intPageUserCount.'<br>');

                if ( !($U->status&$CONF['USHIDDEN']) )
                {

                        if ( checkAuth("viewCalendar",$U->username) )
                        {
                                $intCurrentUserCount++;
                                $intPageUserCount++;
                                $intThisUsersPage = floor($intCurrentUserCount/$intUsersPerPage) + 1;

sorry if the tabs are not exactly the same as in the orig file but for me it looked like there was a missing } somewhere and i wasnt able to find it, so i changed the order of tabs to make it easier.

maybe you can bring this change into the next version.

best regards

stefan

[George]

Thanks schmidts for the find. Looks correct to me on first glimpse. I missed the hidden calendar check.