Holidays only visible after "apply"

If you need support with TeamCal Pro (installation, configuration, usage) post your request here.
Post Reply
snaker
Junior Boarder
Junior Boarder
Posts: 20
Joined: 2010-04-19, 14:44
Location: Germany - Bavaria

Holidays only visible after "apply"

Post by snaker » 2010-04-21, 09:38

Hello there,

at first: great programm, the best i found on the web =)

Unfortunately I have a holiday-problem. I'm using the current version of tcpro runnin on a debian-server installed last week.

This is the problem:
When I open the Calender-View per default I see the current month. But there are no holidays visible. If i press the "apply"-button in the header of this calender-view the same calender-view will be loaded but no the holidays will be shown. It seems that the region (default) will not be loaded when calenderview is selected via the menu but applys on "apply".
URL without apply:
http://server/aufgabenplan/index.php?lang=english

URL after aply:
http://server/aufgabenplan/index.php?la ... ng=english&

I wonder cause i deleted the region "germany" but it creates it but dont know why. My sql-db dind't contain this region in "my_tc_regions" (default -> Default Region -> 0) so where can i delete the "germany" entry, cause i only want to use one region: "default"

The next problem (maybe there's a relation?): when i select the "year calender" via menu theres the same problem but no chance to make the holidays visible ("apply" in the header didn't work here). Pressing the edit-button (edit holidays for this month) didn't show the holidays, too.

In "team cal configuration" I set Default Region for Base Calendar.


##################


During this post I solved the problem by myself:
in the past i used the region Germany later i delted it. But useraccount "admin" used the region "germany" (overwrites the default settings from team cal config) and this entry i found in database. In the usermenu of admin i safed the current view (germany was not selectable). the default region entry now is "default" in the database, too. So problem is solved. Maybe a bug to fix?

-> When deleting region "XYZ" -> update table "my_tc_user_options" where option ="defregion" and value = "XYZ" to "default". If this should work already I didn't say anything but wondering :D
snaker
Junior Boarder
Junior Boarder
Posts: 20
Joined: 2010-04-19, 14:44
Location: Germany - Bavaria

Re:Holidays only visible after "apply"

Post by snaker » 2010-04-21, 09:57

Ok, 1 problem still appears:

View -> Year Calender -> on one of the listed month select "edit holidays for this month". In year calender holidays are visible but in the edit popup they'r not visible:

Url:
http://157.163.130.112/aufgabenplan/edi ... onth=April

if i edit the url like this:
http://157.163.130.112/aufgabenplan/edi ... on=default

it works.

So is the call of the url incorrect or works this function as designed?



EDIT:
and a question by the way:
where can I change the default language which is shown if youre not logged in?
User avatar
George
Platinum Boarder
Platinum Boarder
Posts: 407
Joined: 2004-11-29, 21:20
Are you a spam bot?: No
Contact:

Re:Holidays only visible after "apply"

Post by George » 2010-04-21, 14:35

hi snaker,

thanks for your notes on the issues you experienced with TCP. I will look into those, it seems there is room for improvement and bug fixes.

The default language (before login) is hard coded 'english'. You can change that in the code in functions.tcpro.php, line 1346.

best regards,
george
TeamCal Neo is free for private use but requires licensing for use in a commercial environment:
https://georgelewe.atlassian.net/wiki/s ... eo+License
snaker
Junior Boarder
Junior Boarder
Posts: 20
Joined: 2010-04-19, 14:44
Location: Germany - Bavaria

Re:Holidays only visible after "apply"

Post by snaker » 2010-04-21, 14:47

Thank you for the quick support =)

The tweak with line 1346 works great, maybe you put this opinion to the "teamcalpro configuration" in the "calender display options" but it's not very important ;)

Hope to hear from you soon,

best regards and many thanks from germany ;)
User avatar
George
Platinum Boarder
Platinum Boarder
Posts: 407
Joined: 2004-11-29, 21:20
Are you a spam bot?: No
Contact:

Re:Holidays only visible after "apply"

Post by George » 2010-04-22, 00:18

hi snaker,

I don't know what I was smoking when I coded the region page, but there were quite a few things missing. Thanks again for spotting.

In fact, when a region was updated or deleted, the user options, month templates and config was not updated at all. I have changed that now. Find attached the updated files that should resolve those issues.

Best regards,
George
[file name=tcpro33002beta.zip size=15814]http://www.lewe.com/images/fbfiles/file ... 02beta.zip[/file]
TeamCal Neo is free for private use but requires licensing for use in a commercial environment:
https://georgelewe.atlassian.net/wiki/s ... eo+License
Post Reply